Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After selecting and clearing, tab inserts item #65

Closed
GoNode5 opened this issue Oct 3, 2017 · 7 comments
Closed

After selecting and clearing, tab inserts item #65

GoNode5 opened this issue Oct 3, 2017 · 7 comments
Assignees

Comments

@GoNode5
Copy link

GoNode5 commented Oct 3, 2017

After selecting and clearing, tab inserts item

dropdownopen3

@varnastadeus
Copy link
Member

@GoNode5 it works as expected, since tab selects last highlighted item. If you want to close dropdown without selection you should press ESC or click away.

@GoNode5
Copy link
Author

GoNode5 commented Oct 3, 2017

Cannot agree. Tab is never a way to select anything. Suddenly there is is something chosen because of highlight? Never seen this kind of logic...

@varnastadeus
Copy link
Member

ok, I will do some investigation and will get back to you

@GoNode5
Copy link
Author

GoNode5 commented Oct 3, 2017

Thnx I'am a little biased. The Chosen/Jquery Multiple Select works perfect. I never get any support questions. I did a test with replacing it ng-selects and I was getting questions within an hour (surely about the colors). I strongly suggest to take a look how Chosen works, its also based on years of UX (2011)..

@varnastadeus
Copy link
Member

varnastadeus commented Oct 3, 2017

From Chosen I can see that it does selects value on tab when single, and doesn't when multiple. Will that work? @GoNode5

@GoNode5
Copy link
Author

GoNode5 commented Oct 3, 2017

Sure, sounds great !!! Thnx

@anjmao
Copy link
Member

anjmao commented Oct 3, 2017

@GoNode5 There are a lot of components and they all do it in different way. I think best way is to only close dropdown on tab click and not select any value at all, because It can be selected on enter click. Another argument is that tab purpose is to move to next element, but not to select or change current component value. Also angular material 2 is doing it the same way, not selecting any value.

@varnastadeus varnastadeus self-assigned this Oct 3, 2017
@varnastadeus varnastadeus added this to the Version 1.0.0 milestone Oct 3, 2017
@anjmao anjmao closed this as completed in 5e0ca53 Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants