Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag is not removed when select-container has defined height and scroll is shown. #661

Closed
michalturak opened this issue Jul 5, 2018 · 4 comments · Fixed by #716
Closed
Assignees

Comments

@michalturak
Copy link

Expected behaviour

Tag should be removed when click (X) and select-container has limited height.

Actual behaviour

When tag select has declared maximum container height, clicking on e.g. first item (X) (if select is not focused) is only scroling tags vieport without removing.

https://ng-select-example-mxi8u1.stackblitz.io

steps to reproduce:

  1. Open example.
  2. Click (X) at first item.
  3. Viewport is scrolled and item is still selected.
  4. Clicking on last item (X) without focusing select works fine.

More Info

ng-select version: 2.1.0 (but affects newest too)

browser: all

reproducible in demo page: YES (after modify some css)

@varnastadeus
Copy link
Member

what the issue here? everything seems fine for me and item gets removed

@michalturak
Copy link
Author

I`m sorry,
in edit mode browser was smaller, i updated css body width so please check it now :)

@michalturak
Copy link
Author

Any comment on this? Do you consider it as bug?

@varnastadeus varnastadeus self-assigned this Jul 20, 2018
@varnastadeus
Copy link
Member

yes, I will try to fix it in spare time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants