Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

value="null" when using angular universal #764

Closed
kamilchlebek opened this issue Aug 22, 2018 · 1 comment
Closed

value="null" when using angular universal #764

kamilchlebek opened this issue Aug 22, 2018 · 1 comment

Comments

@kamilchlebek
Copy link
Contributor

kamilchlebek commented Aug 22, 2018

Describe the bug
Assume you've created page with ng-select component that has some set of items but currently does not have any value. When you render page using angular universal, <div class="ng-input"><input role="combobox" type="text" autocomplete="a0eb5d2d24b2" value="null" aria-expanded="false"></div> is being added to HTML which causes NULL text to be visible inside the input. After client app loads NULL disappears. It appears no matter if I'm using template or reactive forms.

To Reproduce

  1. Configure angular universal
  2. Add simple ng-select component to page
  3. Build & run ssr
  4. See error (before client app loads)

Expected behavior
ng-select should not render value="null" as it disappears later

Desktop (please complete the following information):

  • OS: Ubuntu 16.04
  • Browser: Chrome
  • Version: 67.0.3396.99

I've created simple repo with universal and ng-select configured.
https://github.com/kamilchlebek/universal-ng-select

To see this error run:

  1. npm install
  2. npm build
  3. npm start:server
  4. open localhost:4000
@anjmao
Copy link
Member

anjmao commented Oct 3, 2018

Hi @kamilchlebek,

Thanks for repo, PR is welcome for angular universal, that would be great to support it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants