Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed null value display when using angular universal #852

Merged
merged 5 commits into from
Oct 9, 2018
Merged

Fixed null value display when using angular universal #852

merged 5 commits into from
Oct 9, 2018

Conversation

kamilchlebek
Copy link
Contributor

@kamilchlebek kamilchlebek commented Oct 7, 2018 •
edited

  • 99% of work was to add e2e tests for angular universal
  • I've also updated a bit angular dependencies due to some errors while using angular universal. (upgrading dependencies 6.0.0 -> 6.1.0 solved it quickly)

All tests are passing :)

Fixes #764

@coveralls
Copy link

coveralls commented Oct 7, 2018 •
edited

Coverage Status

Coverage remained the same at 94.107% when pulling 46b8186 on kamilchlebek:master into c115f59 on ng-select:master.

@anjmao anjmao self-requested a review October 9, 2018 06:03
anjmao
anjmao approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@anjmao anjmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamilchlebek Super cool, thanks a lot 👍

@anjmao anjmao merged commit 77482c0 into ng-select:master Oct 9, 2018
jakemdunn pushed a commit to jakemdunn/ng-select that referenced this pull request Oct 16, 2018
@kamilchlebek @anjmao
fix: fixed null value display when using angular universal (ng-select…
1215eb2 
…#852)

fixes ng-select#764
NickMele pushed a commit to NickMele/ng-select that referenced this pull request Apr 12, 2019
@kamilchlebek @anjmao
fix: fixed null value display when using angular universal (ng-select…
8fa2ebc 
…#852)

fixes ng-select#764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjmao anjmao anjmao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kamilchlebek @coveralls @anjmao