Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed top value for ng-placeholder class #2152

Closed
wants to merge 3 commits into from

Conversation

ibrahimali7232
Copy link

setting top at 5px was causing placeholder text to be raised up, which looked odd as place holder seems to be not aligned. have changed top value form 5px to 8px fix alignment issue.

ibrahimali7232 and others added 3 commits October 26, 2022 16:14
setting top at 5px was causing placeholder text to be raised up, which looked odd as place holder seems to be not aligned.
have changed top value form 5px to 8px fix alignment issue.
@pavankjadda
Copy link
Collaborator

@ibrahimali7232 Could you add two stackblitz examples

  • One that shows the bug
  • And second one that includes this PR changes

@pavankjadda pavankjadda self-requested a review November 22, 2022 06:00
@pavankjadda pavankjadda self-assigned this Nov 22, 2022
@pavankjadda pavankjadda added needs reproduction needs reproducible example demo page labels Nov 22, 2022
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🎆

@github-actions github-actions bot added the stale label Jan 22, 2023
@github-actions github-actions bot closed this Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants