Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make select with [searchable]="false" focused on click and with keyboard #2229

Merged
merged 4 commits into from
Oct 20, 2023
Merged

feat: Make select with [searchable]="false" focused on click and with keyboard #2229

merged 4 commits into from
Oct 20, 2023

Conversation

kheos31
Copy link
Contributor

@kheos31 kheos31 commented May 10, 2023

@kheos31 kheos31 mentioned this pull request Jun 19, 2023
Closed
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🎆

@github-actions github-actions bot added the stale label Jul 24, 2023
@kheos31
Copy link
Contributor Author

kheos31 commented Jul 24, 2023

Issue #2221 still present on last version and visible on demo page as described. Another issue linked : #2230.

Could you provide a review on this correction please? We can't upgrade ng-select because of this.

Thanks in advance.

@github-actions github-actions bot removed the stale label Jul 25, 2023
@kheos31
Copy link
Contributor Author

kheos31 commented Aug 29, 2023 •
edited

@pavankjadda any news to validate this PR? Thanks in advance

@kheos31
Copy link
Contributor Author

kheos31 commented Oct 6, 2023

Reproduction as video added in the issue : #2221
@pavankjadda Please, how can I do more to make this issue resolved? My team cannot upgrade to Angular 16 currently because of ng-select.. :/

@coveralls
Copy link

Coverage Status

coverage: 93.997% (-0.008%) from 94.005% when pulling 1772abb on kheos31:select-searchable-false-focus into 7a21f6d on ng-select:master.

@pavankjadda pavankjadda self-requested a review October 20, 2023 14:48
@pavankjadda pavankjadda merged commit 4abfcf0 into ng-select:master Oct 20, 2023
6 checks passed
@pavankjadda pavankjadda changed the title Make select with [searchable]="false" focused on click and with keyboard feat: Make select with [searchable]="false" focused on click and with keyboard Oct 20, 2023
@github-actions
Copy link

🎉 This PR is included in version 11.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavankjadda pavankjadda pavankjadda approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kheos31 @coveralls @pavankjadda