Customizable SelectionModel #784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjmao
requested changes
Sep 4, 2018
| @@ -99,6 +100,7 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C | |||
| @Input() searchFn = null; | |||
| @Input() clearSearchOnAdd = true; | |||
| @Input() labelForId = null; | |||
| @Input() selectionModel: SelectionModel = new DefaultSelectionModel(); | |||
varnastadeus
requested changes
Sep 4, 2018
| @@ -99,6 +100,7 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C | |||
| @Input() searchFn = null; | |||
| @Input() clearSearchOnAdd = true; | |||
| @Input() labelForId = null; | |||
| @Input() selectionModel: SelectionModel = new DefaultSelectionModel(); | |||
There was a problem hiding this comment.
I think this should be done differently and you shouldn't pass implementation through input.
You can create abstract class which will serve as your DI token with default implementation. This way you could inject your custom implementation.
There was a problem hiding this comment.
But this has to be done carefully to avoid the bug introduced in release 2.7.0 which binds all ng-select together (cf #787)
|
closing in favor of #785 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.