This repository has been archived by the owner on May 29, 2023. It is now read-only.
feat: provide typesafe mocks for SSR_USER_AGENT & SSR_LOCATION
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsbarsukov
commented
Dec 6, 2022
| @@ -58,6 +58,8 @@ from requests. Use the following helpers to harvest that info: | |||
| **server.ts:** | |||
|
|
|||
| ```typescript | |||
| import {provideLocation, provideUserAgent} from '@ng-web-apis/universal'; | |||
There was a problem hiding this comment.
waterplea
suggested changes
Dec 6, 2022
| export const SSR_LOCATION = new InjectionToken<Location>( | ||
| 'Location object passed from server side', | ||
| {factory: () => new LocationMock()}, |
There was a problem hiding this comment.
You cannot use factory in this token, unfortunately. It takes precedence over providing it because of some weird Injector hierarchy in case of SSR, I couldn't figure it out completely. Instead make them optional and provide fallback here:
https://github.com/ng-web-apis/universal/blob/master/projects/universal/src/constants/universal-user-agent.ts
https://github.com/ng-web-apis/universal/blob/master/projects/universal/src/constants/universal-location.ts
waterplea
approved these changes
Dec 6, 2022
If I've not mistaken It is already 100%: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
SSR_USER_AGENTandSSR_LOCATIONtokens dont have mock-fallbacks.But they are required for prerender-strategy.
What is the new behavior?
Closes #36
Does this PR introduce a breaking change?