Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncPipe and 0 value #187

Closed
artaommahe opened this issue Dec 15, 2016 · 1 comment
Closed

AsyncPipe and 0 value #187

artaommahe opened this issue Dec 15, 2016 · 1 comment
Labels

Comments

@artaommahe
Copy link
Contributor

artaommahe commented Dec 15, 2016

There is error with AsyncPipe

// return cached immediately
if ( inputId in AsyncPipe.subscriptions ) {
  return AsyncPipe.values[ inputId ] || undefined;
}

this will return undefined for 0 value and must return 0

@Hotell Hotell added the bug label Dec 20, 2016
@Hotell
Copy link
Member

Hotell commented Dec 20, 2016

PR are more than welcome! ;)

@Hotell Hotell closed this as completed in 189770e Dec 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants