Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColumnActionManager uses an explicit 'type' switch #1115

Open
jkae opened this issue Dec 11, 2020 · 0 comments
Open

ColumnActionManager uses an explicit 'type' switch #1115

jkae opened this issue Dec 11, 2020 · 0 comments

Comments

@jkae
Copy link
Contributor

jkae commented Dec 11, 2020

I'm noticing that ColumnActionManager.getFromConfig uses an explicit switch on the json "type" field, and would thus need to be overridden if anyone wanted to create extensions to column actions from a plugin.

Is there any chance that this could be made more generic, perhaps through some sort of registration system like DataManager does for descriptors and providers?

(I could do it at some point)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant