Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in batch creation of recipes with non-original jobs #963

Closed
dfaller opened this issue Sep 15, 2017 · 0 comments
Closed

Bug in batch creation of recipes with non-original jobs #963

dfaller opened this issue Sep 15, 2017 · 0 comments

Comments

@dfaller
Copy link
Contributor

dfaller commented Sep 15, 2017

There is a bug in the batch creation process where jobs that are not original to the new batch recipes (i.e. jobs that were created before and are being left as is in the new batch recipes) are still being added to the batch_job models for the batch. This creates the situation where a job belongs in multiple batch_job models, which is invalid and creates problems.

I believe the solution is to place a check in BatchManager._create_batch_models() so that only recipe_job models for new/original jobs (recipe_job.is_original is true) will create a corresponding batch_job model instead of all recipe_job models (which may contain jobs from previous batches).

Investigate and fix.

@dfaller dfaller added this to the Backlog milestone Sep 15, 2017
@mikenholt mikenholt self-assigned this Oct 18, 2017
@dfaller dfaller modified the milestones: Backlog, Sprint 10-23-2017 Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants