-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cli script to install webservice, user and role. #15
Add cli script to install webservice, user and role. #15
Conversation
That's a great contribution! Thanks a lot for your work 🎉 I think it would be a good idea to extend this CLI script to also set the corresponding configuration options within the Without wanting to unnecessarily delay this, I'd still would like to do all these changes in a single coordinated move. This saves us a lot of README back and forth, and should confuse users a little less. I'll look into this the next days and keep you posted 😃 |
… objects, write usage/help info
…ters in quiz_archiver plugin settings
I made some adjustments to the script and added automatic configuration of the quiz archiver plugin settings for the webservice and the user. See added commits for more details :) Next up is the integration into the Moodle Plugin itself. It would probably be good to add an "Autoconfigure"-Button to the settings page, that is disabled once webservice settings are entered. |
Thansk a lot for refining this script, that looks great and is very inspiring! |
I just started to move the whole setup functionality into a local class of the plugin. From here on I'll add proper permission checks so that only site admins can execute it. I'll keep the CLI script available but simply rely on the implementation within the local plugin class. This way we get the best of both worlds: Simpler configuration using the Moodle GUI and support for automatic configuration, e.g., within CI jobs 👍 |
…g_data_generator with proper user_create_user() function call
…ess --force is specified
I now successfully moved all routines into an Currently outstanding tasks:
|
…ible via the plugin admin settings page
Quick update: I created a basic form (not yet pretty 😅) that allows to trigger the automatic installation from the plugins page within the admin UI. This still needs some more work, but technically works. I'll have to get some other tasks done and will come back to finish this after the upcoming Moodle conference in Leipzig :) Here are some screenshots of how it looks now: |
…n instructions to an expendable section
We are getting there. I completed all open tasks, updated the README file and created unit tests for the auto-config routines. Are you able to test, if the current version of this feature works for you? If so, I'd like to finally merge it 👍 |
Very cool - I hope we can test this next week. 👍 |
Just two small notes:
|
@melanietreitinger Have you been able to test the latest version of this feature? |
Hi @ngandrass! We have some remarks regarding the displayed messages:
(A "bonus feature" might be the auto-detection of the docker url which then could be filled in already when starting the auto-installer. 😁) |
Thanks for your suggestions! 👍
Regarding the auto-detection of docker URLs: I don't know how the plugin should determine the worker URL reliably. I could try probing some common names during installation but this will most likely not work reliably. Do you have any idea on how this could work? |
I implemented suggestions 1 to 3 and prepared for release. The autoinstall dialog is now opened within the same tab as the plugin settings page and redirects back to it, hereby eliminating the need for additional information about the required page refresh. Additionally the result is now displayed with a bold font: At the first installation, an info message is displayed, allowing the user to directly choose between automatic installation of manual configuration (via the plugin settings page): I'll finalize this now and create a new release. Thanks a lot for your work and active collaboration with this PR |
CLI script to install the webservice - including user and role - automatically.