fix logging of charge limit #432
Conversation
When subtractChargerLoad is set, calculation of charging limit is different from what has been logged so far. The new log line format correctly represents the applied logic.
Recalculation of consumption needs to consider "subtractChargerLoad" and add charging power if it is set.
The formula can be simplified this way to improve readability. From my POV the check for "conwatts >= 0" could be removed, as master.getConsumption() always returns a value >= 0, but this might change in the future, maybe?
|
If we're changing it, do you think we just change it completely? I'd happily go for a format where we broke the values out clearly, in whatever way looks cleanest - key / value pairs, tabular, whatever would make it more user friendly. I do like your update but I also think if we're fixing it, let's not limit ourselves to how it looks today, let's make it as clear as we can. I'm open to any and all suggestions. |
|
I was playing around with log message formats a little when I implemented the fix, but couldn't find one that convinced me. Something like the following might be better to understand, but I don't really like it, do you? |
|
Part of the issue is that we have 2-6 different ways we can arrive at the limit. There's currently code to try to "retcon" them into one computation for display purposes, which isn't really accurate. In my ideal vision, the log line would actually explain why it's choosing that value to offer. For example:
That would require preserving information from the computation stage about which method governed the outcome this cycle, but might be more user-friendly than more number spew. |
There are a few improvements to the log output of
update_statuses()inTWCManager.py.You may reject the simplification of the calculation if you prefer to keep it the way you implemented it. I found it easier to read if it is simplified the way I did.
Logging looked strange the way it was while charging was ongoing, when
subtractChargerLoadwas set. Log line was e.g. like:⛽ Manager 20 Limiting charging to 6.88A - 6.61A = 6.77A.Or when nominal offer differed from actual:
⛽ Manager 20 Limiting charging to 7.04A - -0.00A = 7.04A.When
subtractChargerLoadis set, it now always has the following format:⛽ Manager 20 Limiting charging to 7.02A - (6.59A - 6.50A) = max 6.93A.