Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make get_max_index() return the max index in frame, so we don't need #644

Closed
wants to merge 1 commit into from
Closed

Make get_max_index() return the max index in frame, so we don't need #644

wants to merge 1 commit into from

Conversation

weliu
Copy link
Contributor

@weliu weliu commented Aug 3, 2016

to do extra calculation

@tatsuhiro-t
Copy link
Member

tatsuhiro-t commented Aug 3, 2016 •
edited

Thank you for PR. This looks good.
One thing I noticed is that "lib/nghttp2_hd.c 100644 → 100755" is shown in "Files changed" view. It looks like file mode is modified. Could you check that it is intentional or not? I think we don't have to change file mode in this PR.

@tatsuhiro-t tatsuhiro-t added this to the v1.14.0 milestone Aug 3, 2016
@weliu
Copy link
Contributor Author

weliu commented Aug 4, 2016

Sorry I made a mistake, the file mode should keep unchanged. I will fire another pull request to fix this. Sorry about the inconvenience.

@weliu weliu closed this Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@weliu @tatsuhiro-t