nghttp2_session: Allow for compiling library with -DNDEBUG set #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a very small fix for building with -DNDEBUG set (as described in 0c49e5d). If assert is compiled out, these functions otherwise fail to compile as they don't return a value.
Can replace the
assert(0)s entirely if that's desirable, but I noticed abort() isn't used anywhere else in the library code so I figure this keeps consistency - if NDEBUG is not set then the abort() call should be compiled out as unreachable code.Thanks for all your work maintaining this library. :)