flarum: package definition #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chickensoupwithrice
force-pushed
the
moss-flarum-2
branch
from
344a23d
to
b64e1e9
Compare
albertchae
commented
Aug 2, 2023
albertchae
commented
Aug 2, 2023
| @@ -2,6 +2,7 @@ | |||
| description = "NgiPkgs"; | |||
|
|
|||
| inputs.nixpkgs.url = "github:NixOS/nixpkgs/nixpkgs-unstable"; | |||
| inputs.php-nixpkgs.url = "github:drupol/nixpkgs?ref=php/add-new-builder"; | |||
There was a problem hiding this comment.
this is the fork/branch for NixOS/nixpkgs#225401. Ideally once that PR is merged, we can just use the same nixpkgs as everything else and remove this php-nixpkgs param
jleightcap
force-pushed
the
moss-flarum-2
branch
6 times, most recently
from
e7a12e5
to
f102e89
Compare
jasonodoom
force-pushed
the
moss-flarum-2
branch
from
4f847b1
to
ccce0c4
Compare
albertchae
commented
Aug 3, 2023
| @@ -15,5 +20,6 @@ | |||
| }; | |||
|
|
|||
| callPackage = newScope (self // nixpkgs-candidates // {inherit callPackage;}); | |||
| php-callPackage = php-newScope (self // nixpkgs-candidates // {inherit callPackage;}); | |||
There was a problem hiding this comment.
Because packaging flarum required us to point to a different fork of nixpkgs, we defined a separate callPackage that uses that fork
jleightcap
force-pushed
the
moss-flarum-2
branch
from
ccce0c4
to
55561fa
Compare
Co-authored-by: Jason Odoom <jasonodoom@gmail.com> Co-authored-by: Anish Lakhwara <anish+git@lakhwara.com> Co-authored-by: Dominic Mills <dominic.millz27@gmail.com> Co-authored-by: Albert Chae <albertchae@users.noreply.github.com> Co-authored-by: Jack Leightcap <jack@leightcap.com> Signed-off-by: Jack Leightcap <jack@leightcap.com>
jleightcap
force-pushed
the
moss-flarum-2
branch
from
55561fa
to
02900b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #10
First attempt here: #23
This PR uses that builder, and so includes some additional temporary inputs in
flake.nix. To usebuildComposerProjectwithout an upstreamcomposer.lock, we've had to commit a valid lockfile locally to the package definition.composer create-project flarum/flarum .yields a valid lockfileOnce the draft PHP builder PR is merged, they can be removed.
PR with patch: #33
nix flake updateto pull in upstreamcallPackageherengipkgs/all-packages.nix
Line 7 in ccce0c4
php-*)ngipkgs/all-packages.nix
Line 23 in ccce0c4
ngipkgs/all-packages.nix
Line 3 in ccce0c4
ngipkgs/all-packages.nix
Line 3 in ccce0c4
ngipkgs/flake.nix
Line 23 in ccce0c4
ngipkgs/flake.nix
Line 28 in ccce0c4