Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permessage-Deflate incorrect working #163

Closed
dennus opened this issue Feb 28, 2017 · 4 comments
Closed

Permessage-Deflate incorrect working #163

dennus opened this issue Feb 28, 2017 · 4 comments
Labels
Milestone

Comments

@dennus
Copy link

dennus commented Feb 28, 2017

Hello!
When websocket client send uncompressed message (with RSV1 = 0) to the channel (with accepted permessage-deflate extension) connection aborting with status code = 1006 and error log contains this message:
2017/02/28 12:04:52 [error] 20226#20226: *6 inflate error : -3 while upgraded connection, client: 10.36.7.197, server: 10.36.7.196, request: "GET /ws_stub HTTP/1.1", host: "10.36.7.196:8090"

But, according RFC 7692, client may send uncompressed message with permessage-deflate enabled, unsetting RSV1 flag.

@xfeep
Copy link
Member

xfeep commented Mar 1, 2017

@dennus Thanks. We 'll follow RFC 7692. But now we only support draft 27 https://tools.ietf.org/html/draft-ietf-hybi-permessage-compression-27 .

@xfeep xfeep added the bug label Mar 1, 2017
@dennus
Copy link
Author

dennus commented Mar 2, 2017

In Draft27, behavior seems indentical :) :
PMCEs use the RSV1 bit of the WebSocket frame header to indicate whether a message is compressed or not, so that an endpoint can choose not to compress messages with incompressible contents

@xfeep
Copy link
Member

xfeep commented Mar 2, 2017

@dennus Thank you!
I really have no time to confirm or fix this issue these days. PRs would be welcome!

@xfeep xfeep added this to the 0.5.1 milestone Nov 21, 2019
@xfeep
Copy link
Member

xfeep commented Nov 21, 2019

@dennus Sorry for so late fix. Commit bd61278 should fix it but we have not found any tool to test it.

@xfeep xfeep closed this as completed Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants