Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle most recently created containers first #1078

Merged
merged 2 commits into from
May 4, 2024
Merged

fix: handle most recently created containers first #1078

merged 2 commits into from
May 4, 2024

Conversation

buchdag
Copy link
Member

@buchdag buchdag commented Dec 19, 2023

This is a proposed fix for #1049. It orders the containers being iterated over by descending creation timestamp (most recent first) instead of by ascending certificate domain name.

Closes #1049

@buchdag buchdag added the type/fix PR for a bug fix label Dec 19, 2023
@buchdag buchdag self-assigned this Dec 19, 2023
@buchdag buchdag marked this pull request as ready for review December 19, 2023 15:22
@buchdag
Copy link
Member Author

buchdag commented Dec 19, 2023

@cpontvieux-systra I know this is ~ 4 months old but your help in validating that this fix #1049 would be welcome.

I've pushed and image that include the fix : nginxproxy/acme-companion:1049

@buchdag buchdag merged commit 624a9ec into main May 4, 2024
36 checks passed
@buchdag buchdag deleted the 1049 branch May 4, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix PR for a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow creation for new domain
1 participant