Get the docker-gen binary from upstream docker image instead of building. #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buchdag
added
type/ci
buchdag
force-pushed
the
docker-gen-from-image
branch
from
0104bd7
to
563c801
Compare
buchdag
force-pushed
the
docker-gen-from-image
branch
from
563c801
to
3336e69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that docker-gen is under the nginx-proxy org, is actively maintained / released and have multi arch images, we can grab the pre built binary from the
nginxproxy/docker-genimage of instead of re building it locally. This will considerably speed up the image build time and allow Dependabot to pick up new docker-gen releases as part of the Docker ecosystem.The PR also removes the nginx-proxy-pull job that turn out to be less efficient than pulling the images in each test.