Skip to content

Commit

Permalink
Hardcode nginx 1.19.3 for use in Docker Images
Browse files Browse the repository at this point in the history
This commit updates both 'Dockerfile' and 'Dockerfile.alpine' to use
'nginx 1.19.3'. This change was implemented after feedback from @buchdag
to be able to use dependabot.
  • Loading branch information
tkw1536 committed Apr 1, 2021
1 parent 6b8cd89 commit 83ca051
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions Dockerfile
@@ -1,6 +1,4 @@
# setup build arguments for version of dependencies to use
ARG NGINX_VERSION=1.19.3

ARG DOCKER_GEN_VERSION=0.7.4
ARG FOREGO_VERSION=0.16.1

Expand Down Expand Up @@ -43,7 +41,7 @@ RUN go get -v ./... && \
CGO_ENABLED=0 GOOS=linux go build -o forego .

# Build the final image
FROM nginx:$NGINX_VERSION
FROM nginx:1.19.3
LABEL maintainer="Jason Wilder mail@jasonwilder.com"

# Install wget and install/updates certificates
Expand Down
4 changes: 1 addition & 3 deletions Dockerfile.alpine
@@ -1,6 +1,4 @@
# setup build arguments for version of dependencies to use
ARG NGINX_VERSION=1.19.3-alpine

ARG DOCKER_GEN_VERSION=0.7.4
ARG FOREGO_VERSION=0.16.1

Expand Down Expand Up @@ -44,7 +42,7 @@ RUN go get -v ./... && \
CGO_ENABLED=0 GOOS=linux go build -o forego .

# Build the final image
FROM nginx:$NGINX_VERSION
FROM nginx:1.19.3-alpine
LABEL maintainer="Jason Wilder mail@jasonwilder.com"

# Install wget and install/updates certificates
Expand Down

0 comments on commit 83ca051

Please sign in to comment.