-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another template for VIRTUAL_PATHs instead of VIRTUAL_HOSTs #33
Comments
@andrefernandes could you re-format your example, because it's quite hard to read right now. You can either indent the whole block with 4 spaces or put three back-ticks before and after the example. |
Sorry for that, it was like 2 AM... Fixed. |
Can you elaborate on why just VIRTUAL_HOSTs does not work? Each container can have multiple virtual hosts defined as well. |
Not much of a big deal. The DNS guys around here cannot create new DNS entries on an acceptable timeframe, while paths are under my control. Actually I prefer VIRTUAL_HOSTs too. De: Jason Wilder [mailto:notifications@github.com] Can you elaborate on why just VIRTUAL_HOSTs does not work? Each container can have multiple virtual hosts defined as well. — |
+1 for this kind of functionality. BTW @andrefernandes, in current state of the
while (I think) it should be
An even more user-friendly template could allow something like
and automatically derive |
For anyone running this in front of a docker registry container... Now that the docker registry v2.0 is out, and they've pretty much done away with They're currently recommending to run a |
Getting this working for the |
Because of reasons, github points md5's link above to incorrect address. The actual link is: master...appropriate:multiple-paths |
I just took a look at the Nginx docs and found that
So I think the only thing that actually needs to be fixed to make my |
I Would love this feature. |
I just took a look at getting my master...appropriate:multiple-paths branch back in shape and it's turning out to be quite painful... There have been quite a few changes in Trying to do a direct rebase seems to be more trouble than it's worth. I think the only viable approach is to reproduce the |
I guess I spoke too soon. I managed to get the branch closer to a mergeable state, though it still doesn't handle the 503 issue I mentioned in my comment from July: #33 (comment) Before doing any more work on that branch, I'd like to see #244 merged. I think it still needs to have the additional lines fixed that are mentioned in this comment: #244 (comment) I'd also like to see the whitespace in the file made consistent again, but that's not a huge deal. |
I finally opened what I think is a mergeable PR for this feature over at #254 Please discuss the patch I've offered at that PR if you're interested in this feature. |
Sure! De: Mike Dillon [mailto:notifications@github.com] I finally opened what I think is a mergeable PR for this feature over at #254#254 Please discuss the patch I've offered at that PR if you're interested in this feature. — |
This features has been added to the It's available now on the |
What about offering other templates for different needs?
I am using the template below to generate several "location" entries for each server. This results on a single domain with a context root for each container (more like port redirection). Serves me well for my single-server Digital Ocean droplet.
You can have several templates available in this project, it is just a matter of mounting the chosen template into "/app/nginx.tmpl" when running the proxy.
The text was updated successfully, but these errors were encountered: