Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update: VIRTUAL_PROTO=https != VIRTUAL_PORT=443 #562

Closed
danbo opened this issue Sep 8, 2016 · 5 comments
Closed

Documentation update: VIRTUAL_PROTO=https != VIRTUAL_PORT=443 #562

danbo opened this issue Sep 8, 2016 · 5 comments

Comments

@danbo
Copy link

danbo commented Sep 8, 2016

Please update the documentation to state that if you select your virtual_proto to be https, the proxy doesn't automatically go to 443 but rather that it has to be specified explicitly.

@jwilder
Copy link
Collaborator

jwilder commented Sep 9, 2016

Would you mind submitting a PR to update it?

r4j4h added a commit to r4j4h/nginx-proxy that referenced this issue Sep 30, 2016
kamermans added a commit to kamermans/nginx-proxy that referenced this issue Sep 30, 2016
@kamermans
Copy link
Contributor

How is it possible that this sat for 21 days, and both me and @r4j4h fixed it just seconds apart? :)

kamermans added a commit to kamermans/nginx-proxy that referenced this issue Jan 12, 2017
@italomaia
Copy link

I have VIRTUAL_PROTO set to https and VIRTUAL_PORT to 443, yet, default.conf still points proxies to port 80:

# bin.italomaia.com
upstream bin.italomaia.com {
}
server {
	server_name app.italomaia.com;
	listen 80 ;
	access_log /var/log/nginx/access.log vhost;
	include /etc/nginx/vhost.d/default;
	location / {
		proxy_pass https://app.italomaia.com;
	}
}

Is that really all there is to do?

@kamermans
Copy link
Contributor

That's all that is needed, but please make sure you are setting these variables on your application's webserver container, not the nginx-proxy container.

@tkw1536
Copy link
Collaborator

tkw1536 commented Apr 28, 2022

Seems resolved, closing.

@tkw1536 tkw1536 closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants