-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation update: VIRTUAL_PROTO=https != VIRTUAL_PORT=443 #562
Comments
Would you mind submitting a PR to update it? |
Should resolve Issue nginx-proxy#562
How is it possible that this sat for 21 days, and both me and @r4j4h fixed it just seconds apart? :) |
I have VIRTUAL_PROTO set to https and VIRTUAL_PORT to 443, yet, default.conf still points proxies to port 80:
Is that really all there is to do? |
That's all that is needed, but please make sure you are setting these variables on your application's webserver container, not the nginx-proxy container. |
Seems resolved, closing. |
Please update the documentation to state that if you select your virtual_proto to be https, the proxy doesn't automatically go to 443 but rather that it has to be specified explicitly.
The text was updated successfully, but these errors were encountered: