New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various code health chores #2127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for that last commit, I don't want to spark an endless debate but I find two space tabs make code harder to read, especially on GitHub.
OK, I'll do 4 spaces. Or would you prefer something else? |
Done. I also pushed some new commits:
|
545763e
to
0034bb1
Compare
The value is actually a slice/array of containers so it should be pluralized.
Planned future changes will introduce more embedded templates, and the ability to pass the globals to the templates will be useful.
No behavior changes, just cleanups.