Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: don't install wget inside images #2231

Merged
merged 1 commit into from May 3, 2023
Merged

build: don't install wget inside images #2231

merged 1 commit into from May 3, 2023

Conversation

buchdag
Copy link
Member

@buchdag buchdag commented Apr 30, 2023

This was only used a (long) while ago to get docker-gen and/or forego binaries.

@buchdag buchdag added type/build PR that affect the build system or external dependencies scope/dockerfile labels Apr 30, 2023
@buchdag buchdag requested a review from rhansen April 30, 2023 15:33
@buchdag buchdag self-assigned this Apr 30, 2023
@buchdag
Copy link
Member Author

buchdag commented May 2, 2023

To be honest I'm not certain we need ca-certificates either.

@buchdag buchdag merged commit d2e62c2 into main May 3, 2023
2 checks passed
@buchdag buchdag deleted the remove-wget branch May 3, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhansen rhansen rhansen approved these changes

Assignees

@buchdag buchdag

Labels
scope/dockerfile type/build PR that affect the build system or external dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@buchdag @rhansen