Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for grpcs protocol #2321

Merged
merged 1 commit into from Jan 16, 2024
Merged

Add support for grpcs protocol #2321

merged 1 commit into from Jan 16, 2024

Conversation

theFra985
Copy link
Contributor

No description provided.

@buchdag
Copy link
Member

buchdag commented Dec 9, 2023

Hi. I'm not sure I understand the point of this PR. The added code is already there under the grpc proto.

@buchdag buchdag closed this Dec 10, 2023
@theFra985
Copy link
Contributor Author

theFra985 commented Jan 16, 2024

Hi, sorry for the late reply, it would support grpcs if it had an option to prefix the grpc_pass URL with grpcs instead of grpc.
My issue was the lack of grpcs:// protocol support as the rule added in the grpc PR doesn't include the grpcs protocol while matching the specified protocol and while deploying PMM under nginx-proxy it was required to have grpcs:// as the protocol instead of grpc:// for it to work properly.
An alternative would be to match both of them in the same condition but the grpc PR lacks an option to use grpcs:// as protocol in the grpc_pass call

@buchdag
Copy link
Member

buchdag commented Jan 16, 2024

@theFra985 my bad, I misunderstood the change.

@buchdag buchdag merged commit d46881f into nginx-proxy:main Jan 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feat PR for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants