Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: support custom 'docker compose' command #2349

Merged
merged 1 commit into from Dec 20, 2023

Conversation

pini-gh
Copy link
Contributor

@pini-gh pini-gh commented Dec 19, 2023

Enable overriding default 'docker compose' command with environment variable 'DOCKER_COMPOSE'. This way docker compose v1 is still supported with:

$ DOCKER_COMPOSE=docker-compose pytest

This is important because people using the Debian packaged docker compose are stuck to v1.

@buchdag
Copy link
Member

buchdag commented Dec 19, 2023

@pini-gh thanks for the PR, do you think you could document the environment variable in test/README.md ?

@buchdag buchdag added type/test PR that add missing tests or correct existing tests status/pr-needs-docs This PR needs new or additional documentation labels Dec 19, 2023
@pini-gh
Copy link
Contributor Author

pini-gh commented Dec 19, 2023

Sure.

Enable overriding default 'docker compose' command with environment variable
'DOCKER_COMPOSE'. This way docker compose v1 is still supported with:

  $ DOCKER_COMPOSE=docker-compose pytest

This is important because people using the Debian packaged docker compose
are stuck to v1.
@pini-gh pini-gh force-pushed the pini-support-docker-compose-v1 branch from 9d364a6 to 9e77e81 Compare December 20, 2023 08:30
@buchdag buchdag merged commit 4f85eef into nginx-proxy:main Dec 20, 2023
2 checks passed
@pini-gh pini-gh deleted the pini-support-docker-compose-v1 branch December 20, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/pr-needs-docs This PR needs new or additional documentation type/test PR that add missing tests or correct existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants