Fix xpass and xfails test_restart_while_missing_cert.py #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I also stumbled upon this about a year ago, can't remember why I did not remove those at the time (might be that the test where still occasionally failing). I'll go ahead and merge this PR, if those tests start failing again we'll revert and investigate. |
buchdag
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests in
stress_tests\test_restart_while_missing_cert.pywere being marked as xfailed and some others are partial. But I do not see a special reason. (nor could find in the commit history).So I removed the xfail and incremental markers. And fixed 2 tests.
Now CI should have 100% passed score.
If there was a reason they should be xfail / xpass where I was not aware off just delete this PR.