Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upd: Boost worker_connections from 1024 to 10240. #973

Merged
merged 1 commit into from Apr 28, 2021

Conversation

cadesalaberry
Copy link
Contributor

@cadesalaberry cadesalaberry commented Nov 10, 2017

It's very common to have thousands of clients, especially for a public website. I stopped counting the amount of websites I've seen went down because of the low defaults.

source

@cl1ent
Copy link

cl1ent commented Oct 15, 2018

Bump. I'd really like to see this merged and as far as I know there is no reason not to

@huan
Copy link

huan commented Apr 28, 2021

This PR is really helpful for heavy WebSocket service like mine, please merge.

@buchdag
Copy link
Member

buchdag commented Apr 28, 2021

I checked that ulimit -n is sufficient in both nginx and nginx:alpine images, lgtm.

Unfortunately I can't rebase and push to Sparted/nginx-proxy to launch the tests.

Merging anyway, I'll watch the push triggered test and revert if anything goes wrong.

@buchdag buchdag merged commit 35df872 into nginx-proxy:main Apr 28, 2021
@huan
Copy link

huan commented Apr 28, 2021

@buchdag Thank you very much for merging this PR, appreciate it!

When could we expect to have the docker image published?

@buchdag
Copy link
Member

buchdag commented Apr 28, 2021

It's already available from either nginxproxy/nginx-proxy:latest or the legacy jwilder/nginx-proxy:latest

@buchdag
Copy link
Member

buchdag commented Apr 28, 2021

And also as nginxproxy/nginx-proxy:0.9 / nginxproxy/nginx-proxy:0.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants