Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Integration Test for REST API #141

Merged
merged 60 commits into from Jan 24, 2023
Merged

Add Integration Test for REST API #141

merged 60 commits into from Jan 24, 2023

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Dec 9, 2022 •
edited

Proposed changes

  • Added integration tests for API
  • Added api integration-test to Makefile
  • Changed paths of Dockerfiles in Makefile
  • Added swagger install to make tools

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@aphralG aphralG self-assigned this Dec 9, 2022
@github-actions github-actions bot added dependencies documentation Improvements or additions to documentation labels Dec 9, 2022
dhurley
dhurley reviewed Dec 9, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
scripts/docker/nginx-oss/ubuntu/entrypoint.sh Outdated Show resolved Hide resolved
test/integration/api/api_test.go Show resolved Hide resolved
test/integration/api/api_test.go Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Dec 9, 2022 •
edited

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 857bfa7
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/63cfdf1211e1a70008e53b6c

@aphralG aphralG marked this pull request as ready for review December 12, 2022 08:25
@aphralG aphralG changed the title Draft: Add Integration Test for REST API Add Integration Test for REST API Dec 12, 2022
@aphralG aphralG removed the documentation Improvements or additions to documentation label Dec 12, 2022
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 12, 2023
@aphralG aphralG added chore Pull requests for routine tasks and removed documentation Improvements or additions to documentation labels Jan 12, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 13, 2023
@aphralG aphralG merged commit 13a9088 into main Jan 24, 2023
@oliveromahony oliveromahony deleted the integration-test branch February 10, 2023 15:49
@dhurley dhurley removed documentation Improvements or additions to documentation dependencies labels Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliveromahony oliveromahony oliveromahony approved these changes

@dhurley dhurley dhurley approved these changes

@craigell craigell craigell approved these changes

@Dean-Coakley Dean-Coakley Awaiting requested review from Dean-Coakley

Assignees

@aphralG aphralG

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aphralG @oliveromahony @dhurley @craigell