remove fields from trace logging #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliveromahony
requested review from
dhurley,
Dean-Coakley,
craigell and
aphralG
Dean-Coakley
approved these changes
Mar 13, 2023
| "config_data": config.ConfigData, | ||
| "action": config.Action, | ||
| }).Trace("Writing config") | ||
| defer jsonLogger.Writer().Close() |
There was a problem hiding this comment.
I think it's slightly preferred to close the writer as soon as possible(Optional)
Suggested change
| defer jsonLogger.Writer().Close() | |
| jsonLogger.Writer().Close() |
aphralG
approved these changes
Mar 14, 2023
dhurley
approved these changes
Mar 14, 2023
4 tasks
oliveromahony
added a commit
that referenced
this pull request
Mar 14, 2023
* remove fields from trace logging (#251) --------- Co-authored-by: Oliver O'Mahony <oliveromahony+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove information from trace logging level for configuration push
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.md)