Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty access item when log format is changed #270

Merged
merged 22 commits into from
May 4, 2023
Merged

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Mar 31, 2023

Proposed changes

Log Format for access log was not being updated when a new config was applied.

Now when a new config is applied the access log tailer and log format are updated.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Mar 31, 2023
@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks dependencies labels Mar 31, 2023
@netlify
Copy link

netlify bot commented Mar 31, 2023

Deploy Preview for agent-public-docs ready!

Name Link
🔨 Latest commit 8a4a5a6
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64538be907e7580008716c92
😎 Deploy Preview https://deploy-preview-270--agent-public-docs.netlify.app/nginx-agent/getting-started
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@aphralG aphralG marked this pull request as ready for review March 31, 2023 13:41
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 19, 2023
@aphralG aphralG merged commit c978574 into main May 4, 2023
27 checks passed
@aphralG aphralG deleted the fix-empty-access-item branch May 4, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants