chore: Address issues identified by linter in src/core/environment.go #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The exec.Command() function was being passed an incorrect argument instead of the actual command to be executed
* commit vendor files updated following a make deps
* Replace deprecated io/ioutils with os read/write function calls * Rename files variable in func ReadDirectory() due to identical name in another library * Appropriately handle file close * Appropriately deferred handle file close
✅ Deploy Preview for agent-public-docs canceled.
|
|
Running |
Dean-Coakley
approved these changes
Apr 17, 2023
oliveromahony
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
io/ioutilswithosread/write function callsfunc ReadDirectory()due to identical name in another librarymake clean; make build; make deps; make unit-testChecklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)