Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Agent to support backpressure from server #299

Merged
merged 21 commits into from
May 10, 2023

Conversation

achawla2012
Copy link
Contributor

@achawla2012 achawla2012 commented Apr 19, 2023

Proposed changes

  • Command server and metrics server to send gRPC Unavailable status error code if server is not accepting request for certain duration.
  • Server to send Pause command to Agent (Added Proto) having information about backoffsettings.
  • Agent would then update its backoff settings according to Backoff-settings sent by server in pause command.
  • Refactored BackoffSettings struct.
    • Moved BackoffSettings to package backoff
    • Update to
      type BackoffSettings struct {
          InitialInterval time.Duration
          MaxInterval     time.Duration
          MaxElapsedTime  time.Duration
          Multiplier      float64
          Jitter          float64
      }
      

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation labels Apr 19, 2023
@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 5a613d7
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/645a926dbc34a0000930a577

sdk/proto/agent.proto Show resolved Hide resolved
sdk/proto/agent.proto Show resolved Hide resolved
@achawla2012 achawla2012 changed the title Update Agent details for backpressure Update Agent to support backpressure from server May 1, 2023
sdk/backoff.go Outdated Show resolved Hide resolved
sdk/client/commander.go Outdated Show resolved Hide resolved
sdk/client/commander.go Outdated Show resolved Hide resolved
src/plugins/commander.go Outdated Show resolved Hide resolved
src/plugins/commander.go Outdated Show resolved Hide resolved
src/plugins/metrics_sender.go Outdated Show resolved Hide resolved
src/plugins/metrics_sender.go Outdated Show resolved Hide resolved
src/plugins/commander.go Show resolved Hide resolved
@dhurley dhurley removed documentation Improvements or additions to documentation dependencies labels May 10, 2023
@dhurley dhurley merged commit 2850ca0 into nginx:main May 10, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants