Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable disable features #300

Merged
merged 55 commits into from
Jun 6, 2023
Merged

Enable disable features #300

merged 55 commits into from
Jun 6, 2023

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Apr 21, 2023 •
edited

Proposed changes

Added ability to enable and disable features

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Apr 21, 2023 •
edited

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 3f1205f
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/647f69f1ebdc7d0007f99ae1

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies enhancement New feature or request labels Apr 21, 2023
@aphralG aphralG self-assigned this May 4, 2023
@aphralG aphralG marked this pull request as ready for review May 9, 2023 16:04
@aphralG aphralG changed the title Draft: Enable disable features Enable disable features May 16, 2023
oliveromahony
oliveromahony reviewed May 17, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@oliveromahony oliveromahony self-requested a review May 17, 2023 13:52
@oliveromahony
Copy link
Contributor

This looks mostly Ok. I think you missed the scenario where the Management Plane sends a AgentConnectResponse and sends the list of features there. There also should be a scenario where the AgentConfig can get updated outside of the Registration flow. This seems to be possible via a command containing AgentConfig

oliveromahony
oliveromahony reviewed Jun 2, 2023
View reviewed changes
src/core/pipe.go Outdated Show resolved Hide resolved
dhurley
dhurley reviewed Jun 6, 2023
View reviewed changes
src/plugins/nginx.go Outdated Show resolved Hide resolved
src/plugins/nginx.go Outdated Show resolved Hide resolved
dhurley
dhurley reviewed Jun 6, 2023
View reviewed changes
src/plugins/agent_api.go Outdated Show resolved Hide resolved
dhurley
dhurley approved these changes Jun 6, 2023
View reviewed changes
src/plugins/features.go Outdated Show resolved Hide resolved
@aphralG aphralG merged commit 5974615 into main Jun 6, 2023
27 checks passed
@aphralG aphralG deleted the enable-disable-features branch June 6, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliveromahony oliveromahony oliveromahony approved these changes

@dhurley dhurley dhurley approved these changes

@Dean-Coakley Dean-Coakley Awaiting requested review from Dean-Coakley

@craigell craigell Awaiting requested review from craigell

Assignees

@aphralG aphralG

Labels
chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aphralG @oliveromahony @dhurley @Dean-Coakley