Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GetNetOverflow in linux #301

Merged
merged 1 commit into from
May 3, 2023
Merged

Conversation

u5surf
Copy link
Contributor

@u5surf u5surf commented Apr 23, 2023

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Apr 23, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 0cdb674
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/6446f790a8c5b60008e17e78

@github-actions github-actions bot added the chore Pull requests for routine tasks label Apr 23, 2023
@u5surf u5surf marked this pull request as ready for review April 23, 2023 15:17
@oliveromahony
Copy link
Contributor

oliveromahony commented Apr 24, 2023

Thanks so much for your contribution @u5surf - Is it possible to run make deps as part of this PR and commit the changes?

Is it also possible to provide output for different operating systems based on this change?

Thanks

* use nstat -az
* fix nginx#277 partially
@u5surf
Copy link
Contributor Author

u5surf commented Apr 24, 2023

@oliveromahony

Thanks so much for your contribution. Is it possible to run make deps as part of this PR and commit the changes?

Thanks reviewing. I could include the changes in commit now.

Is it also possible to provide output for different operating systems based on this change?

Sorry, I don’t have any time to prepare other runtime environment especially freebsd. It should be prepared as a virtual machine like VirtualBox. I will obtain enough time to see other os behavior because we will enter the holiday season in next Friday.

@oliveromahony
Copy link
Contributor

@u5surf I can ask @craigell to take a look at the different environments. @craigell would you be able to do this?

@craigell
Copy link
Contributor

@u5surf I can ask @craigell to take a look at the different environments. @craigell would you be able to do this?

I've taken a look and approved the request.

@dhurley dhurley merged commit 39a759b into nginx:main May 3, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GetNetOverflow function to use nstat instead of netstat
4 participants