Close controller before exiting #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for agent-public-docs canceled.
|
github-actions
bot
added
chore
ryepup
reviewed
May 22, 2023
achawla2012
approved these changes
May 22, 2023
nkashiv
force-pushed
the
NMS-42480
branch
2 times, most recently
from
cb5a1e9
to
dd2b76d
Compare
oliveromahony
approved these changes
Jun 12, 2023
aphralG
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nginx-agent, when being stopped by sending SIGTERM (default way of stopping a service), closes all opened streams with RST_STREAM with error code 0x8 (CANCEL) (https://httpwg.org/specs/rfc7540.html#ErrorCodes ), which leads to extra warnings and inability to track actual response codes in nginx proxy layer.
Proposed changes
With these changes, when the agent will receive the SIGTERM signal the controller will be closed before exiting.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)