Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration overview #324

Merged
merged 13 commits into from
Jun 26, 2023
Merged

Add configuration overview #324

merged 13 commits into from
Jun 26, 2023

Conversation

oCHRISo
Copy link
Collaborator

@oCHRISo oCHRISo commented May 29, 2023

Proposed changes

Adding configuration section to docs
Providing overview of ways to configure NGINX Agent (conf file, CLI and Environment vars)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@oCHRISo oCHRISo added the documentation Improvements or additions to documentation label May 29, 2023
@netlify
Copy link

netlify bot commented May 29, 2023

Deploy Preview for agent-public-docs ready!

Name Link
🔨 Latest commit 1f587ff
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/649995cc0861680007e391de
😎 Deploy Preview https://deploy-preview-324--agent-public-docs.netlify.app/nginx-agent/configuration-overview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@oCHRISo oCHRISo marked this pull request as draft May 29, 2023 13:23
@oCHRISo oCHRISo marked this pull request as ready for review June 8, 2023 10:57
oCHRISo and others added 2 commits June 9, 2023 11:17
Co-authored-by: Jon Torre <78599298+Jcahilltorre@users.noreply.github.com>
hugo/content/configuration-overview.md Outdated Show resolved Hide resolved
hugo/content/configuration-overview.md Show resolved Hide resolved
hugo/content/configuration-overview.md Outdated Show resolved Hide resolved
hugo/content/configuration-overview.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@fda5ae8). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #324   +/-   ##
=======================================
  Coverage        ?   67.08%           
=======================================
  Files           ?      113           
  Lines           ?    12714           
  Branches        ?        0           
=======================================
  Hits            ?     8529           
  Misses          ?     3613           
  Partials        ?      572           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oCHRISo oCHRISo merged commit 3639b7f into main Jun 26, 2023
27 checks passed
@oCHRISo oCHRISo deleted the nginx-agent-configuration branch June 26, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants