doc: add comments for each field in the SecurityViolationEvent proto definition #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for agent-public-docs canceled.
|
github-actions
bot
added
chore
mohamed-gougam
requested review from
oliveromahony,
oCHRISo,
dhurley,
sanathkumarbs,
Dean-Coakley,
craigell,
olli-holmala and
aphralG
ghost
reviewed
Jun 1, 2023
olli-holmala
reviewed
Jun 1, 2023
olli-holmala
reviewed
Jun 1, 2023
olli-holmala
reviewed
Jun 1, 2023
olli-holmala
reviewed
Jun 1, 2023
olli-holmala
approved these changes
Jun 1, 2023
Dean-Coakley
changed the title
mohamed-gougam
force-pushed
the
nap-monitoring-add-proto-doc
branch
from
eaf086e
to
5ea5666
Compare
Dean-Coakley
reviewed
Jun 1, 2023
|
LGTM, thank you! |
sanathkumarbs
approved these changes
Jun 1, 2023
mohamed-gougam
force-pushed
the
nap-monitoring-add-proto-doc
branch
from
5ea5666
to
bfee61c
Compare
mohamed-gougam
force-pushed
the
nap-monitoring-add-proto-doc
branch
from
bfee61c
to
911c5ee
Compare
Thanks for the catch |
Dean-Coakley
approved these changes
Jun 2, 2023
aphralG
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add documentation about each of the fields in the SecurityViolationEvent message.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)