Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: specified predefined access log format (#340) #349

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

u5surf
Copy link
Contributor

@u5surf u5surf commented Jun 17, 2023

Fixed: #340

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

* nginx has the predefined access log format below.
* https://nginx.org/en/docs/http/ngx_http_log_module.html
* if the log_format isn't specified or combined, it should be
  predefined one.
@netlify
Copy link

netlify bot commented Jun 17, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit b579858
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/649035a49bbd9b0008c666dc

@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks dependencies labels Jun 17, 2023
sdk/config_helpers.go Outdated Show resolved Hide resolved
@u5surf u5surf requested a review from dhurley June 20, 2023 04:26
@craigell craigell self-requested a review June 20, 2023 15:50
@oliveromahony oliveromahony merged commit b51d462 into nginx:main Jun 20, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log formats without names and access logs without names will have log tailing fail silently
5 participants