Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitor NGINX logs for alert messages after NGINX reload #351

Merged
merged 7 commits into from
Jun 27, 2023
Merged

Monitor NGINX logs for alert messages after NGINX reload #351

merged 7 commits into from
Jun 27, 2023

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Jun 20, 2023

Proposed changes

Monitor NGINX logs for alerts after an NGINX reload

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Jun 20, 2023
@netlify
Copy link

netlify bot commented Jun 20, 2023 •
edited

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit dbc4c25
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/649adf9173c899000820f578

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Jun 20, 2023
@oliveromahony
Copy link
Contributor

should we include [crit] as well? https://www.keycdn.com/support/nginx-error-log#nginx-error-log-severity-levels

oliveromahony
oliveromahony reviewed Jun 22, 2023
View reviewed changes
src/core/nginx.go Outdated Show resolved Hide resolved
dhurley
dhurley reviewed Jun 26, 2023
View reviewed changes
src/plugins/nginx.go Outdated Show resolved Hide resolved
src/plugins/nginx.go Outdated Show resolved Hide resolved
src/plugins/nginx.go Outdated Show resolved Hide resolved
@aphralG aphralG merged commit 7317dec into main Jun 27, 2023
27 checks passed
@aphralG aphralG deleted the monitor-error-logs-for-alert branch June 27, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliveromahony oliveromahony oliveromahony approved these changes

@dhurley dhurley dhurley approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@craigell craigell craigell approved these changes

Assignees

@aphralG aphralG

Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aphralG @oliveromahony @dhurley @Dean-Coakley @craigell