Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout to integration tests setup #360

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Add timeout to integration tests setup #360

merged 1 commit into from
Jun 29, 2023

Conversation

Dean-Coakley
Copy link
Contributor

@Dean-Coakley Dean-Coakley commented Jun 28, 2023 •
edited

Proposed changes

  • Add timeout to integration test setup. Test will now fail after 20 seconds if it cannot start agent service rather than default of 10 minutes.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@Dean-Coakley Dean-Coakley self-assigned this Jun 28, 2023
@netlify
Copy link

netlify bot commented Jun 28, 2023 •
edited

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit eb6d4cb
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/649c6b8e54a85400072396c2

@github-actions github-actions bot added the chore Pull requests for routine tasks label Jun 28, 2023
@oliveromahony
Copy link
Contributor

On failure again we should pull the logs from the container. Perhaps store them as part of the pipeline artefacts?

@Dean-Coakley Dean-Coakley merged commit ec22400 into main Jun 29, 2023
27 checks passed
@Dean-Coakley Dean-Coakley deleted the add-integration-test-timeout branch June 29, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliveromahony oliveromahony oliveromahony approved these changes

@dhurley dhurley dhurley approved these changes

@craigell craigell Awaiting requested review from craigell

@aphralG aphralG Awaiting requested review from aphralG

Assignees

@Dean-Coakley Dean-Coakley

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dean-Coakley @oliveromahony @dhurley