Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Average memory metrics instead of summing #362

Merged
merged 3 commits into from
Jul 3, 2023

Conversation

Giners
Copy link
Contributor

@Giners Giners commented Jun 30, 2023

Proposed changes

This PR makes changes to how the following metrics are calculated:

  • nginx.workers.mem.vms
  • nginx.workers.mem.rss

Previously they were calculated by taking the sum of all the measurements over a polling period. Now they are to be averaged. This aligns with how the metrics are expected to be displayed in Amplify.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Jun 30, 2023

Deploy Preview for agent-public-docs ready!

Name Link
🔨 Latest commit 732ff23
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/649ef2d05ca76b00088874da
😎 Deploy Preview https://deploy-preview-362--agent-public-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Jun 30, 2023
@oliveromahony oliveromahony merged commit b88e571 into nginx:main Jul 3, 2023
28 checks passed
@oliveromahony oliveromahony deleted the avg-mem-metrics branch July 3, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants