Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate loopback interface metrics to a metric report #381

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Populate loopback interface metrics to a metric report #381

merged 2 commits into from
Jul 10, 2023

Conversation

achawla2012
Copy link
Contributor

Proposed changes

  • Allow loopback interface metrics in a metric report sent to backend server.
  • Add tests.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Jul 6, 2023 •
edited

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit f6dc502
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64a70ea980599e000869c70b

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Jul 6, 2023
@achawla2012 achawla2012 changed the title Add loopback interface metrics to a metric report Populate loopback interface metrics to a metric report Jul 6, 2023
@oliveromahony oliveromahony merged commit ca9c7d6 into nginx:main Jul 10, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliveromahony oliveromahony oliveromahony approved these changes

@aphralG aphralG aphralG approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@achawla2012 @oliveromahony @aphralG