Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ParseInt instead of Atoi when converting process id string to an int #384

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented Jul 7, 2023

Proposed changes

Use ParseInt instead of Atoi when converting process id string to an int

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 99515c4
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64a837779b3e880007560745

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Jul 7, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.16 ⚠️

Comparison is base (02f86ca) 67.48% compared to head (99515c4) 67.32%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
- Coverage   67.48%   67.32%   -0.16%     
==========================================
  Files         113      113              
  Lines       12676    12676              
==========================================
- Hits         8554     8534      -20     
- Misses       3554     3576      +22     
+ Partials      568      566       -2     
Impacted Files Coverage Δ
.../agent/v2/src/core/metrics/sources/nginx_worker.go 30.95% <0.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Dean-Coakley Dean-Coakley merged commit 171563b into main Jul 10, 2023
28 checks passed
@Dean-Coakley Dean-Coakley deleted the fix-integer-overflow-issue branch July 10, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants