Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor NGINX logs for critical & error messages after NGINX reload #385

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Jul 10, 2023

Proposed changes

Monitor NGINX logs for critical & error after an NGINX reload

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Jul 10, 2023
@netlify
Copy link

netlify bot commented Jul 10, 2023

Deploy Preview for agent-public-docs ready!

Name Link
🔨 Latest commit 2ec0afa
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64afdcac080c610008566a92
😎 Deploy Preview https://deploy-preview-385--agent-public-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Jul 10, 2023
@aphralG aphralG marked this pull request as ready for review July 11, 2023 10:48
@aphralG aphralG changed the title Monitor NGINX logs for critical messages after NGINX reload Monitor NGINX logs for critical & error messages after NGINX reload Jul 13, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 84.00% and project coverage change: +0.29 🎉

Comparison is base (0e16af7) 67.26% compared to head (2ec0afa) 67.56%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
+ Coverage   67.26%   67.56%   +0.29%     
==========================================
  Files         113      113              
  Lines       12743    12695      -48     
==========================================
+ Hits         8572     8577       +5     
+ Misses       3601     3550      -51     
+ Partials      570      568       -2     
Impacted Files Coverage Δ
src/core/message.go 100.00% <ø> (ø)
src/core/network/network.go 31.48% <ø> (+0.21%) ⬆️
src/core/os.go 42.85% <0.00%> (ø)
...ed-metrics/tables/priority_table/priority_table.go 77.27% <ø> (+4.54%) ⬆️
...b.com/nginx/agent/v2/src/core/metrics/aggregate.go 88.29% <ø> (-0.25%) ⬇️
.../agent/v2/src/core/metrics/collectors/container.go 90.69% <ø> (ø)
...inx/agent/v2/src/core/metrics/collectors/system.go 92.85% <ø> (+5.35%) ⬆️
...t/v2/src/core/metrics/sources/cgroup/cgroup_cpu.go 83.87% <ø> (-0.13%) ⬇️
...com/nginx/agent/v2/src/core/metrics/sources/cpu.go 76.31% <ø> (-0.61%) ⬇️
...om/nginx/agent/v2/src/core/metrics/sources/disk.go 69.56% <ø> (-1.27%) ⬇️
... and 31 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aphralG aphralG merged commit 705e2bd into main Jul 13, 2023
28 checks passed
@aphralG aphralG deleted the monitor-error-logs-for-critical branch July 13, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants