Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve enable/disable features #393

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Improve enable/disable features #393

merged 3 commits into from
Jul 13, 2023

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Jul 11, 2023

Proposed changes

Made changes to features.go & config_reader.go:

  • config_reader.go now sends a list of features to be enabled instead of each feature individually
  • features.go instead of sending each plugin for each feature individually all plugins that need to be enabled are sent to be registered in pipe.go

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Jul 11, 2023
@netlify
Copy link

netlify bot commented Jul 11, 2023 •
edited

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit db26b50
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64ae8da41ff0280008f0e33b

@aphralG aphralG marked this pull request as ready for review July 11, 2023 09:52
@github-actions github-actions bot added chore Pull requests for routine tasks dependencies enhancement New feature or request labels Jul 11, 2023
@aphralG aphralG merged commit 3e999b8 into main Jul 13, 2023
29 checks passed
@aphralG aphralG deleted the enable-disable-features-remaining branch July 13, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliveromahony oliveromahony oliveromahony approved these changes

@dhurley dhurley dhurley approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@craigell craigell Awaiting requested review from craigell

Assignees

@aphralG aphralG

Labels
chore Pull requests for routine tasks dependencies enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aphralG @oliveromahony @dhurley @Dean-Coakley