Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix integration test failures #396

Merged
merged 29 commits into from
Jul 21, 2023
Merged

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Jul 11, 2023

Proposed changes

Made changes to the agentless-entrypoint.sh to stop integration tests from randomly failing.
Added Out Put Logs to Integration Test job in pipeline to capture to docker logs if test fails.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Jul 11, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit e0adaeb
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64b960107bb82d0007ab0bf3

@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.18 🎉

Comparison is base (ff83ff7) 67.35% compared to head (e0adaeb) 67.53%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
+ Coverage   67.35%   67.53%   +0.18%     
==========================================
  Files         113      113              
  Lines       12725    12725              
==========================================
+ Hits         8571     8594      +23     
+ Misses       3582     3561      -21     
+ Partials      572      570       -2     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aphralG aphralG requested review from Dean-Coakley and oliveromahony and removed request for Dean-Coakley July 20, 2023 16:04
@aphralG aphralG self-assigned this Jul 20, 2023
@aphralG aphralG marked this pull request as ready for review July 20, 2023 16:05
@aphralG aphralG changed the title DRAFT: investigating integration test failures fix integration test failures Jul 20, 2023
@aphralG aphralG merged commit c945263 into main Jul 21, 2023
28 checks passed
@aphralG aphralG deleted the investigate-failing-integration-test branch July 21, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants