Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test failures #412

Merged
merged 25 commits into from
Jul 25, 2023
Merged

Unit test failures #412

merged 25 commits into from
Jul 25, 2023

Conversation

oliveromahony
Copy link
Contributor

@oliveromahony oliveromahony commented Jul 19, 2023 •
edited

Proposed changes

Investigation into unit test failures. Changes to tidy some resources

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Jul 19, 2023 •
edited

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit c0fe0a7
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64bfb2b56fa2f2000741b872

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Jul 19, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 19, 2023
@oliveromahony oliveromahony changed the title Draft: Unit test failures Unit test failures Jul 20, 2023
aphralG
aphralG reviewed Jul 21, 2023
View reviewed changes
src/plugins/commander.go Outdated Show resolved Hide resolved
@oliveromahony
Copy link
Contributor Author

Waiting for #401 before I merge

@oliveromahony oliveromahony merged commit 26eb063 into main Jul 25, 2023
28 checks passed
@oliveromahony oliveromahony deleted the unit-test-failures branch July 25, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley dhurley dhurley approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@aphralG aphralG aphralG approved these changes

@craigell craigell Awaiting requested review from craigell

Assignees
No one assigned
Labels
chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oliveromahony @dhurley @Dean-Coakley @aphralG