Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable log rotation #414

Merged
merged 10 commits into from
Aug 3, 2023
Merged

enable log rotation #414

merged 10 commits into from
Aug 3, 2023

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Jul 21, 2023

Proposed changes

Add log rotation configuration & Added to README and Docs

  # log files are rotated every day
  daily
  # log files are rotated if they grow bigger than 5M
  size 5M
  # truncate the original log file after creating a copy
  copytruncate
  # remove rotated logs older than 10 days
  maxage 10
  # log files are rotated 10 times before being removed
  rotate 10
  # old log files are compressed
  compress

Fixes #310

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Jul 21, 2023

Deploy Preview for agent-public-docs ready!

Name Link
🔨 Latest commit 44afb54
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64cb70ab159daf0008780d98
😎 Deploy Preview https://deploy-preview-414--agent-public-docs.netlify.app/nginx-agent/configuration-overview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (996d150) 67.57% compared to head (44afb54) 67.55%.
Report is 1 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
- Coverage   67.57%   67.55%   -0.03%     
==========================================
  Files         113      113              
  Lines       12766    12764       -2     
==========================================
- Hits         8627     8623       -4     
- Misses       3569     3572       +3     
+ Partials      570      569       -1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 24, 2023
@aphralG aphralG changed the title enable log rotate enable log rotation Jul 24, 2023
@aphralG aphralG requested a review from oCHRISo July 26, 2023 08:55
@aphralG aphralG requested a review from dhurley July 26, 2023 10:01
README.md Outdated Show resolved Hide resolved
@dhurley dhurley added the chore Pull requests for routine tasks label Aug 2, 2023
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
@aphralG aphralG merged commit bba2f84 into main Aug 3, 2023
28 checks passed
@aphralG aphralG deleted the enable-log-rotate branch August 3, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nginx-agent packages do not have logrotate configuration
7 participants