Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove memory leaks #422

Merged
merged 17 commits into from
Aug 8, 2023
Merged

Remove memory leaks #422

merged 17 commits into from
Aug 8, 2023

Conversation

oliveromahony
Copy link
Contributor

@oliveromahony oliveromahony commented Jul 27, 2023

Proposed changes

Added some contexts to different places that memory leaks were occurring

Setting PROFILE_ADDRESS environmental variable will enable pprof:
e.g. PROFILE_ADDRESS=localhost:6060 go run main.go
will run pprof on localhost:6060

Screenshot 2023-07-27 at 16 45 17

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 89ef204
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64d250182490140008b12f73

@oliveromahony oliveromahony changed the title Remove memory leaks Draft: Remove memory leaks Jul 27, 2023
@github-actions github-actions bot added chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation labels Jul 27, 2023
@oliveromahony oliveromahony changed the title Draft: Remove memory leaks WIP: Remove memory leaks Jul 27, 2023
@oliveromahony oliveromahony changed the title WIP: Remove memory leaks Remove memory leaks Jul 27, 2023
src/core/environment.go Outdated Show resolved Hide resolved
src/core/environment.go Outdated Show resolved Hide resolved
src/core/environment.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 62.26% and project coverage change: +0.06% 🎉

Comparison is base (3d9d248) 67.43% compared to head (89ef204) 67.49%.
Report is 4 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
+ Coverage   67.43%   67.49%   +0.06%     
==========================================
  Files         113      113              
  Lines       12764    12806      +42     
==========================================
+ Hits         8607     8644      +37     
- Misses       3588     3592       +4     
- Partials      569      570       +1     
Files Changed Coverage Δ
src/core/network/network.go 31.48% <0.00%> (ø)
src/core/nginx.go 46.39% <0.00%> (ø)
src/core/environment.go 52.27% <71.05%> (+0.67%) ⬆️
src/core/process.go 66.66% <100.00%> (+3.70%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliveromahony oliveromahony merged commit 8686b9e into main Aug 8, 2023
28 checks passed
@oliveromahony oliveromahony deleted the cpu-benchmarks-agent branch August 8, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants